Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated notebooks via odh-sync-updater-12711100946 GitHub action #836

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Updated notebooks via odh-sync-updater-12711100946 GitHub action #836

merged 1 commit into from
Jan 15, 2025

Conversation

Bobbins228
Copy link

Description

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@Bobbins228 Bobbins228 mentioned this pull request Jan 15, 2025
Closed
@atheo89
Copy link
Member

atheo89 commented Jan 15, 2025

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Jan 15, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atheo89

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jiridanek
Copy link
Member

/lgtm

it passed all gha checks, except those that always fail, so it should be more or less fine to merge

@jiridanek
Copy link
Member

/override "build (cuda-jupyter-tensorflow-ubi9-python-3.11) / build"
/override "build (rocm-jupyter-tensorflow-ubi9-python-3.11) / build"

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 15, 2025

@jiridanek: Overrode contexts on behalf of jiridanek: build (cuda-jupyter-tensorflow-ubi9-python-3.11) / build, build (rocm-jupyter-tensorflow-ubi9-python-3.11) / build

In response to this:

/override "build (cuda-jupyter-tensorflow-ubi9-python-3.11) / build"
/override "build (rocm-jupyter-tensorflow-ubi9-python-3.11) / build"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@atheo89
Copy link
Member

atheo89 commented Jan 15, 2025 •
edited
Loading

Thanks Mark and Jiri for taking look on this, i will move on to manual merge in order to go on with the release.

@atheo89 atheo89 merged commit 8ab739e into opendatahub-io:main Jan 15, 2025
14 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyatmiami andyatmiami Awaiting requested review from andyatmiami

@jiridanek jiridanek Awaiting requested review from jiridanek

Assignees

@jiridanek jiridanek

@atheo89 atheo89

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Bobbins228 @atheo89 @jiridanek @codeflare-machine-account